tests for integration classes#145
Closed
kitchen wants to merge 22 commits intoDataDog:masterfrom
Closed
Conversation
Contributor
Author
|
I made each test into a separate commit for easier perusal of the changes related to that test. I can squash this before merging if necessary. |
Contributor
|
@kitchen looks great, thanks for your efforts! We'll be reviewing this more thoroughly shortly, and have it slated for an upcoming release |
Member
Member
|
@kitchen just wanted to let you know there was a typo in the changelog that shipped with the released puppet module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are tests for the integration classes.
I have left out 2 integrations:
datadog_agent::integration::directoryThis integration doesn't appear to be functional. Catalogs which include it cannot compile. I've opened an issue at datadog_agent::integrations::directory is not functional? #144 for this.
datadog_agent::integration::genericThe work I plan to do next on this will obviate the need for the 'generic' integration, so it didn't make sense adding tests for something that's going to go away Real Soon Now™